Support hpack include directives #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `generateCabalFile` argument that allows us to pre-genereate the cabal file, thus allowing us to create an environment where hpack can successfully find included files. We also just read the package.yaml file directly to get the name rather than by calling readYAML, since include directives lead to unparseable YAML. Resolves cdepillabout#47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
generateCabalFileargument that allows us to pre-genereate the cabal file, thus allowing us to create an environment where hpack can successfully find included files.We also just read the package.yaml file directly to get the name rather than by calling readYAML, since include directives lead to unparseable YAML.
Resolves #47
I know you haven't had a lot of capacity to review PRs lately. No worries at all if you won't have time to take a look at this for a while. Take as long as you need!