Skip to content

Commit

Permalink
fix(release): publish a GitHub release even if a particular package m…
Browse files Browse the repository at this point in the history
…anager fails (#441)
  • Loading branch information
xiehan authored Aug 27, 2024
1 parent 18a5866 commit 8e090f7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 35 deletions.
6 changes: 6 additions & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,12 @@ export class CdktfProviderProject extends cdk.JsiiProject {
setSafeDirectory
);

// always publish a new GitHub release, even when publishing to a particular package manager fails
const releaseWorkflow = this.tryFindObjectFile(
".github/workflows/release.yml"
);
releaseWorkflow?.addOverride("jobs.release_github.needs", "release");

// ensure we don't fail if the release file is not present
const checkExistingTagStep = (
this.release as any
Expand Down
40 changes: 5 additions & 35 deletions test/__snapshots__/index.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8e090f7

Please sign in to comment.