Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make author address overridable #383

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

mbialon
Copy link
Contributor

@mbialon mbialon commented Jan 2, 2024

Related issue

Fixes #382

Description

The author's address was hard-coded. I made it settable from the config.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 2, 2024

CLA assistant check
All committers have signed the CLA.

@ansgarm
Copy link
Contributor

ansgarm commented Jan 2, 2024

Hi @mbialon 👋

Thank you for the PR 👍 Looks good so far.

You marked this PR as a draft – Is there anything you want to add before we give it a proper review?

@mbialon mbialon marked this pull request as ready for review January 2, 2024 17:08
@mbialon mbialon requested a review from a team as a code owner January 2, 2024 17:08
@mbialon mbialon requested review from mutahhir and Maed223 and removed request for a team January 2, 2024 17:08
@mbialon
Copy link
Contributor Author

mbialon commented Jan 2, 2024

Hi @ansgarm

Nothing to add. Marked it as ready for review.

@ansgarm ansgarm force-pushed the feat-override-author-address branch from 3e6e6c2 to 8e2d666 Compare January 4, 2024 17:00
@ansgarm ansgarm merged commit 2e0adcf into cdktf:main Jan 4, 2024
7 checks passed
@ansgarm
Copy link
Contributor

ansgarm commented Jan 4, 2024

Thanks for the PR @mbialon 👍

@mbialon mbialon deleted the feat-override-author-address branch January 5, 2024 13:46
Copy link

I'm going to lock this pull request because it has been closed for at least 7 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make author address overridable
3 participants