Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix go get usage for Golang within readme #393

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

mutahhir
Copy link
Contributor

Description

Our readme shows an incorrect command to execute for Golang in order to use the prebuilt providers within CDKTF projects.

This PR updates that language to be clearer to the users.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir requested a review from a team as a code owner January 16, 2024 12:52
@mutahhir mutahhir requested review from ansgarm and DanielMSchmidt and removed request for a team January 16, 2024 12:52
@mutahhir mutahhir force-pushed the fix/update-go-readme branch from 010f7a4 to 2475f55 Compare January 16, 2024 13:19
@DanielMSchmidt DanielMSchmidt merged commit 84fd002 into main Jan 17, 2024
7 checks passed
@DanielMSchmidt DanielMSchmidt deleted the fix/update-go-readme branch January 17, 2024 09:00
Copy link

I'm going to lock this pull request because it has been closed for at least 7 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants