Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMP #128

Merged
merged 2 commits into from
Nov 21, 2023
Merged

SAMP #128

merged 2 commits into from
Nov 21, 2023

Conversation

bmatthieu3
Copy link
Collaborator

@bmatthieu3 bmatthieu3 commented Oct 30, 2023

Subscribes to Mtypes:

  • table.load.votable
  • image.load.fits
  • coord.pointAt.sky
  • coverage.load.moc.fits
  • script.aladin.send

I need to put a button to ask for the user connection permission

@onekiloparsec
Copy link
Contributor

onekiloparsec commented Nov 5, 2023

Hello Matthieu. I was about to add a comment at the end of my last PR, but I guess here is a good place too. It seems a bit crazy to me to add more stuff given the actual quality of the JS code and the jQuery dependency that is still there. I have worked a bit on that, but given the amount of work, I found no path yet to submit something. Just for the record, Arcsecond still doesn't use AladinLite v3 because it is unstable...

@bmatthieu3
Copy link
Collaborator Author

Hi @onekiloparsec ,
SAMP is a VO standard and this development of integrating it inside Aladin Lite is done inside the frame of the SKA (Square Kilometer Array) radioastronomy mission. sampjs is a very mature library allowing to send and receive messages to a SAMP Hub. I do not see any intersection of that with other dependency, mainly jquery.
I am currently working on a new UI interface that relies on vanilla JS DOM manipulation instead of jquery ones. This should not remove all the jquery calls but a good part of it, especially those that are inside Aladin.js file.
Concerning your unstability issues, do not hesitate to create issues with minimal examples linked. That will help us a lot to reproduce the errors.

@onekiloparsec
Copy link
Contributor

Hi Matthieu. I understand, and these will certainly be great additions to Aladin Lite. I am just wondering in terms of priorities, given the amount of work just to make the JS code look more manageable.

For me unstabilities preventing the complete integration of the tool itself is by far a more urgent matter than adding more stuff. But, anyway. I will try to make a simple project to reproduce the problem, if time permits.

@bmatthieu3 bmatthieu3 merged commit 02a23ea into develop Nov 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants