Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade vite-to-level-await #162

Merged
merged 1 commit into from
May 29, 2024

Conversation

ManonMarchand
Copy link
Member

@ManonMarchand ManonMarchand commented May 29, 2024

This PR switches to reference stable versions of healpix and moc libraries

This was done in commit 93a7c7c .

This PR only upgrades the vite-top-level-await dependency now

Fixes #159

@ManonMarchand ManonMarchand changed the title Fix changes upstream healpix and mocs Point to stable healpix and mocs libraries May 29, 2024
@ManonMarchand ManonMarchand marked this pull request as draft May 29, 2024 09:16
@ManonMarchand
Copy link
Member Author

Looks like the healpix cells and the grid are broken by this. Switching to draft.

@bmatthieu3 bmatthieu3 force-pushed the fix-changes-upstream-healpix-and-mocs branch from dc264e7 to 95b8bfe Compare May 29, 2024 09:37
@bmatthieu3
Copy link
Collaborator

@fxpineau @ManonMarchand - The intersect_parallel from special_point_finder and the previous one (now commented in cdshealpix) seem to behave differently. For the moment you can compile aladin lite but the grid does not work. I will see once I come back.

@ManonMarchand ManonMarchand marked this pull request as ready for review May 29, 2024 11:44
@ManonMarchand ManonMarchand merged commit c881d1c into develop May 29, 2024
2 checks passed
@ManonMarchand ManonMarchand deleted the fix-changes-upstream-healpix-and-mocs branch May 29, 2024 11:45
@ManonMarchand
Copy link
Member Author

Merged the commit on vite-top-level-await upgrade since the other one was already pushed to develop

@ManonMarchand ManonMarchand changed the title Point to stable healpix and mocs libraries upgrade vite-to-level-await May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile: Changes upstream in cdshealpix
2 participants