-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: planetary name resolvers (openstreetmap and gazetteer of planetary features) #103
Merged
ManonMarchand
merged 17 commits into
cds-astro:master
from
Xen0Xys:fix/planetary-skycoord
Sep 16, 2024
Merged
feat: planetary name resolvers (openstreetmap and gazetteer of planetary features) #103
ManonMarchand
merged 17 commits into
cds-astro:master
from
Xen0Xys:fix/planetary-skycoord
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you also add an entry in the changelog? And maybe some mocked python tests? |
Xen0Xys
force-pushed
the
fix/planetary-skycoord
branch
5 times, most recently
from
August 5, 2024 09:07
d016228
to
991045a
Compare
bmatthieu3
reviewed
Aug 5, 2024
Xen0Xys
force-pushed
the
fix/planetary-skycoord
branch
from
August 6, 2024 08:31
3d74b31
to
9cd9a8c
Compare
…ey body is a planetary body
…ame object as expected
ManonMarchand
force-pushed
the
fix/planetary-skycoord
branch
from
September 16, 2024 07:14
ad72d64
to
1079336
Compare
ManonMarchand
changed the title
Merge support for planetary skycoord to Master
add: planetary name resolvers (openstreetmap and gazetteer of planetary features)
Sep 16, 2024
ManonMarchand
changed the title
add: planetary name resolvers (openstreetmap and gazetteer of planetary features)
feat: planetary name resolvers (openstreetmap and gazetteer of planetary features)
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.