_execute: return tuple of success, logs #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust _execute to return the success/failure status of the command and the commands output as two separate values, paired. Adjust s2i_inner to reflect the altered return type, and to assign the returned output to s2i_build_log in the success and failure cases. Fixes cekit#72. Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
added a commit
to jmtd/redhat-openjdk-container-images
that referenced
this pull request
Nov 28, 2024
The jlink feature will initially ship as TP. Repurpose older unit test to check for the TP warning (older test is redundant as it only worked if jmods are installed). The test depends upon this being merged first: cekit/behave-test-steps#73 https://issues.redhat.com/browse/OPENJDK-3038 Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
rnc
approved these changes
Nov 28, 2024
jmtd
added a commit
to jmtd/redhat-openjdk-container-images
that referenced
this pull request
Dec 2, 2024
The jlink feature will initially ship as TP. Repurpose older unit test to check for the TP warning (older test is redundant as it only worked if jmods are installed). The test depends upon this being merged first: cekit/behave-test-steps#73 https://issues.redhat.com/browse/OPENJDK-3038 Signed-off-by: Jonathan Dowland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust _execute to return the success/failure status of the command and the commands output as two separate values, paired.
Adjust s2i_inner to reflect the altered return type, and to assign the returned output to s2i_build_log in the success and failure cases.
Fixes #72.