-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(share/availability): simplify light availability #3895
Conversation
walldiss
commented
Oct 28, 2024
- simplification refactoring of Samples selection code
- remove squareSampler
- remove binary encode/decode in favour of json
- removal of no longer relevant TODOs
- rename "cache" naming artefacts from the past
- use height in logs instead of root hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional request is to move dah validation check in availability.go
earlier in the SharesAvailability
function -- ideally in the beginning. It doesn't make sense where it currently is.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3895 +/- ##
==========================================
+ Coverage 44.83% 45.33% +0.50%
==========================================
Files 265 308 +43
Lines 14620 21764 +7144
==========================================
+ Hits 6555 9867 +3312
- Misses 7313 10844 +3531
- Partials 752 1053 +301 ☔ View full report in Codecov by Sentry. |
19f1067
to
c81592b
Compare
Had to rebase the PR on main, and commit history is lost. Here is what changed after last reviews
|
# Conflicts: # share/availability/light/availability.go