fix(blob)!: tendermint compatible commitment proof json marshall

[zvolin]

Fixes #3918

Please note: this PR is BREAKING as commitment proof encoding has changed.

[rach-id]

Thanks for opening this PR.

Do you think we will still need the JSON marshall/unmarshall after merging this #3821 to main?

[zvolin]

yes, it uses coretypes.RowProof. Everything that comes from core (tendermint fork) should be serialized with tendermint json encoder / decoder as it treats 64 bit integers differently (stringifies them)

[rach-id]

thanks for your response @zvolin. And why is this change useful?

[rach-id]

After second thinking about this, I guess you're right, this needs fixing

[zvolin]

And why is this change useful?

to have unified representation of objects regardless whether they are returned from celestia-node api or tendermint rest api. Moreover, tendermint implementations in different languages can have the rules how to encode types in different level than in go, namely tendermint-rs bakes how the type is meant to be encoded on type level, not encoder level, so in lumina we had to patch tendermint to achieve celestia-node compatible representation, but we could never be compatible with both tendermint and celestia-node.

tl;dr it originates from us wishing to drop tendermint-rs fork but I believe it's a good thing in general

[vgonkivs]

@zvolin could you please fix lint?

[zvolin]

switched to marshaling whole type as per #3930 (comment)

[vgonkivs]

Linter failed.

[zvolin]

should be good now, sorry

[renaynay]

@zvolin some broken tests

[vgonkivs]

blob_fuzz_test.go:69: invalid 64-bit integer encoding "64", expected string

[zvolin]

🤞 sd '"(total|index)":([0-9]+)' '"$1":"$2"' blob/testdata/**/*.json

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/api-breaks@4a90605). Learn more about missing BASE report.

Additional details and impacted files

@@                  Coverage Diff                  @@
##             feature/api-breaks    #3929   +/-   ##
=====================================================
  Coverage                      ?   45.40%           
=====================================================
  Files                         ?      307           
  Lines                         ?    21812           
  Branches                      ?        0           
=====================================================
  Hits                          ?     9904           
  Misses                        ?    10846           
  Partials                      ?     1062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vgonkivs]

LGTM 🚀 . Thanks @zvolin

[zvolin]

make test-integration SHORT=true TAGS=sync passes for me locally 🤔

[vgonkivs]

The test seems to be flaky.