add logic for nodeType validations, set ClusteIP for SVCs by default

charts/celestia-node/templates/_helpers.tpl

@@ -38,20 +38,21 @@ Return the proper image name for the otel agent
 {{- end -}}
 
 {{/*
-Validate the node.settings.nodeType value.
+Validate the node.settings.nodeType value against the first argument in node.args.
 */}}
 {{- define "node.validateValues.nodeType" -}}
 {{- if not (hasKey .Values.node.settings "nodeType") -}}
 Node type is not set. Must be one of 'bridge', 'full', or 'light'.
 {{- else if and (ne .Values.node.settings.nodeType "bridge") (ne .Values.node.settings.nodeType "full") (ne .Values.node.settings.nodeType "light") -}}
 Invalid node type: {{ .Values.node.settings.nodeType }}. Must be one of 'bridge', 'full', or 'light'.
+{{- else if not (eq .Values.node.settings.nodeType (first .Values.node.args)) -}}
+The nodeType value ({{ .Values.node.settings.nodeType }}) does not match the first argument in args ({{ first .Values.node.args }}).
 {{- end -}}
 {{- end -}}
 
 # TODO: add validations for values
 # Remember to add the validation message to NOTES.txt at the end ({{- include "node.validateValues" . }})
 {{/*
-{{/*
 Compile all warnings into a single message and fail the deployment if there are any.
 */}}
 {{- define "node.validateValues" -}}

charts/celestia-node/values.yaml

@@ -729,9 +729,9 @@ service:
       prometheus: 8890
     ## @param service.internal.clusterIP node internal service Cluster IP
     ## e.g.:
-    ## clusterIP: None
+    ## clusterIP: None # We use headless mode by default for stateful workloads.
     ##
-    clusterIP: ""
+    clusterIP: "None"
     ## @param service.internal.annotations Additional custom annotations for node internal service
     ##
     annotations: {}
@@ -755,8 +755,8 @@ service:
     enabled: true
     ## @param service.external.type node external service type
     ##
-    # -- external service type, LoadBalancer by default
-    type: LoadBalancer
+    # -- external service type, ClusterIP by default
+    type: ClusterIP
     ## @param service.external.ports.p2p Node external service P2P port
     ## @param service.external.ports.rest Node external service REST port
     ## @param service.external.ports.rpc Node external service RPC port