feat: add helm charts #1
Conversation
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
.github/workflows/lint-test.yaml
Outdated
| - name: Run chart-testing (list-changed) | ||
| id: list-changed | ||
| run: | | ||
| changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }}) | ||
| if [[ -n "$changed" ]]; then | ||
| echo "changed=true" >> "$GITHUB_OUTPUT" | ||
| fi |
There was a problem hiding this comment.
unless these tests take a long time to run, I would remove this and just have them always run.
One benefit of them always running is if there is a dependency update, that doesn't change any helm chart files, there might be an issue that gets missed because the tests didn't run.
| | Name | Email | Url | | ||
| | ---- | ------ | --- | | ||
| | Celestia Labs | | <https://github.com/celestiaorg/celestia-helm-charts> | |
There was a problem hiding this comment.
why not just delete the email column?
There was a problem hiding this comment.
This is auto-generated helm docs
There was a problem hiding this comment.
nit: might as well spell out the name for the filename.
There was a problem hiding this comment.
This is the common term in helm charts for that resource
| | Name | Email | Url | | ||
| | ---- | ------ | --- | | ||
| | Celestia Labs | | <https://github.com/celestiaorg/celestia-helm-charts> | |
There was a problem hiding this comment.
This is auto-generated helm docs
There was a problem hiding this comment.
This is the common term in helm charts for that resource
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Overview