Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: setting type of node #2

Merged
merged 29 commits into from
Jul 5, 2024
Merged

feat: setting type of node #2

merged 29 commits into from
Jul 5, 2024

Conversation

aWN4Y25pa2EK
Copy link
Contributor

  1. Enables UDP
  2. Adds arabica-11 example

tty47
tty47 previously approved these changes Jun 27, 2024
View reviewed changes
smuu
smuu previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aWN4Y25pa2EK aWN4Y25pa2EK marked this pull request as ready for review June 27, 2024 10:02
@smuu smuu dismissed their stale review June 27, 2024 10:30

changes

@smuu smuu changed the title Arabica-11 feat: setting type of node Jun 27, 2024
smuu
smuu requested changes Jun 27, 2024
View reviewed changes
charts/celestia-node/values.yaml Outdated Show resolved Hide resolved
charts/celestia-node/templates/statefulset.yaml Outdated Show resolved Hide resolved
charts/celestia-node/values.yaml Outdated Show resolved Hide resolved
charts/celestia-node/values.yaml Outdated Show resolved Hide resolved
@aWN4Y25pa2EK
Copy link
Contributor Author

  • moved nodeType to node.settings
  • added logic validation for nodeType deployment
  • added readinessprobe to be the same as the one used by the FN
  • added anchors to simplify the values.fies

@smuu smuu merged commit ed78bef into main Jul 5, 2024
1 of 2 checks passed
@smuu smuu deleted the task/add-arabica-2 branch July 5, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tty47 tty47 tty47 left review comments

@smuu smuu smuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aWN4Y25pa2EK @smuu @tty47