-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ensures VerifyLeafHashes rejects leafHashes with wrong namespaces #207
feat: ensures VerifyLeafHashes rejects leafHashes with wrong namespaces #207
Conversation
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 95.39% 94.03% -1.37%
==========================================
Files 5 5
Lines 565 570 +5
==========================================
- Hits 539 536 -3
- Misses 15 19 +4
- Partials 11 15 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…onsistency-verify-leafhashes
After investigating the code to determine the cause of the coverage decline, I have discovered the reason: In the updated version of the code, the
Therefore, it is safe to disregard the reduced coverage and proceed with merging the PR. |
Overview
Closes #183. The modifications in this PR are also in line with empowering light clients to furnish BEFPs for proofs that encounter unsuccessful verification outcomes (where the early termination of verification upon encountering invalid leaf hashes, with mismatching namespaces, gives a clear indication of the failure root cause, enabling them to decide on whether to craft BEFPs or not accordingly).
Checklist