Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

da: add grpc metrics #329

Open
wants to merge 83 commits into
base: celestia-develop
Choose a base branch
from
Open

da: add grpc metrics #329

wants to merge 83 commits into from

Conversation

tuxcanfly
Copy link
Collaborator

@tuxcanfly tuxcanfly commented Jan 18, 2024

Overview

This PR adds gRPC metrics for the DA client. The methods are:

  • da_blob_get for op-node
  • da_blob_submit for op-batcher

the subsystem is da_client.

Sample metrics from devnet:

  • op-node:
# HELP op_node_default_da_client_request_duration_seconds Histogram of DA client request durations
# TYPE op_node_default_da_client_request_duration_seconds histogram
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="0.005"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="0.01"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="0.025"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="0.05"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="0.1"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="0.25"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="0.5"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="1"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="2.5"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="5"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="10"} 13
op_node_default_da_client_request_duration_seconds_bucket{method="da_blob_get",le="+Inf"} 13
op_node_default_da_client_request_duration_seconds_sum{method="da_blob_get"} 0.035445792
op_node_default_da_client_request_duration_seconds_count{method="da_blob_get"} 13
# HELP op_node_default_da_client_requests_total Total DA requests initiated by the opnode's DA client
# TYPE op_node_default_da_client_requests_total counter
op_node_default_da_client_requests_total{method="da_blob_get"} 13
  • op-batcher:
# TYPE op_batcher_default_da_client_request_duration_seconds histogram
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="0.005"} 0
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="0.01"} 0
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="0.025"} 0
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="0.05"} 0
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="0.1"} 1
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="0.25"} 2
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="0.5"} 9
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="1"} 24
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="2.5"} 26
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="5"} 26
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="10"} 26
op_batcher_default_da_client_request_duration_seconds_bucket{method="da_blob_submit",le="+Inf"} 26
op_batcher_default_da_client_request_duration_seconds_sum{method="da_blob_submit"} 16.246764839000004
op_batcher_default_da_client_request_duration_seconds_count{method="da_blob_submit"} 26
# HELP op_batcher_default_da_client_requests_total Total DA requests initiated by the opnode's DA client
# TYPE op_batcher_default_da_client_requests_total counter
op_batcher_default_da_client_requests_total{method="da_blob_submit"} 26

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tuxcanfly tuxcanfly force-pushed the celestia-develop branch 2 times, most recently from 4c64973 to 9931de7 Compare June 7, 2024 16:05
@tuxcanfly tuxcanfly force-pushed the celestia-develop branch 3 times, most recently from 906ea8b to 2454b20 Compare June 20, 2024 17:15
@tuxcanfly tuxcanfly force-pushed the celestia-develop branch 2 times, most recently from b0d5401 to f97945e Compare July 2, 2024 14:03
@tuxcanfly tuxcanfly force-pushed the celestia-develop branch 8 times, most recently from 34b600e to 35208f7 Compare July 15, 2024 17:16
@tuxcanfly tuxcanfly force-pushed the celestia-develop branch 3 times, most recently from fc81490 to cf7d8cd Compare July 20, 2024 17:31
@tuxcanfly tuxcanfly force-pushed the celestia-develop branch 3 times, most recently from 2f756d9 to 872d1f8 Compare August 8, 2024 00:07
@tuxcanfly tuxcanfly force-pushed the celestia-develop branch 2 times, most recently from 1b944c7 to 3426d0b Compare September 23, 2024 22:24
@tuxcanfly tuxcanfly force-pushed the celestia-develop branch 4 times, most recently from ce660d0 to 4c05eb4 Compare October 3, 2024 19:42
@tuxcanfly tuxcanfly force-pushed the celestia-develop branch 2 times, most recently from 3303b89 to d8de0fc Compare October 23, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants