Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop support for infectious #154

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 13, 2023

Closes #151

@rootulp rootulp self-assigned this Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #154 (38dc343) into master (91acbb1) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   81.60%   81.64%   +0.03%     
==========================================
  Files           8        7       -1     
  Lines         560      512      -48     
==========================================
- Hits          457      418      -39     
+ Misses         63       56       -7     
+ Partials       40       38       -2     
Impacted Files Coverage Δ
codecs.go 50.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp requested review from liamsi and musalbas March 13, 2023 19:42
@rootulp rootulp marked this pull request as ready for review March 13, 2023 19:42
@rootulp
Copy link
Collaborator Author

rootulp commented Mar 16, 2023

@liamsi @musalbas is this safe to merge?

@musalbas
Copy link
Member

musalbas commented Mar 16, 2023

I wouldn't say it's unsafe to merge

One can never guarantee that software is safe to merge

@liamsi
Copy link
Member

liamsi commented Mar 16, 2023

@liamsi @musalbas is this safe to merge?

It is OK to remove infectious library, yes.

@rootulp rootulp merged commit 1fdcc31 into celestiaorg:master Mar 16, 2023
@rootulp rootulp deleted the rp/drop-infectious branch March 16, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider dropping support for Infectious
4 participants