Skip to content

Commit

Permalink
fix use_line_collection issues
Browse files Browse the repository at this point in the history
I thought that the use_line_collection error was from the shap package, but after all it is reproduced by matplotlib and the cause is in the yellowbrics package, that is, yellowbrics should remove use_line_collection.
I opened an issue: DistrictDataLabs/yellowbrick#1312 and as soon as it is resolved, we should update the yellowbrics version
  • Loading branch information
celestinoxp committed Jan 31, 2024
1 parent 1ece378 commit 1cb727a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 1 addition & 2 deletions requirements-optional.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Analysis
# some dependency uses use_line_collection, so in shap 0.44.0 a use_line_collection error appears
shap<0.44.0 # fix use_line_collection error/removed
shap>=0.44.0 # 0.44.0 fixes matplotlib use_line_collection error
interpret>=0.2.7
umap-learn>=0.5.2
# pyyaml 5.3.1 to fix ydata-profiling requirements pyyaml 5.4.1 can't build
Expand Down
2 changes: 2 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ wurlitzer; platform_system != 'Windows'
# Plotting
matplotlib>=3.8.2
scikit-plot>=0.3.7
# yellowbrick<=1.5, have conflict with recent matplotlib by use_line_collection error
# should use yellowbrick>1.5 when fixed (https://github.com/DistrictDataLabs/yellowbrick/issues/1312)
yellowbrick>=1.4
plotly>=5.14.0
kaleido>=0.2.1
Expand Down

0 comments on commit 1cb727a

Please sign in to comment.