[WIP] Temporary fix for crash on Spell::UpdateOriginalCasterPointer() with #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only return full who with gm on Only use same faction replies in channel Co-Authored-By: blitzi <[email protected]>
Fix crash in player relocation Fix crash in targeted movement generator log Crashfix attempt Temp fix for bg event crash BG crashfix Co-Authored-By: blitzi <[email protected]>
Option to make players on taxi visible from afar Instant taxi option Save armory feed Solocraft Module Fix repair cost return values Save more stats to db Fix console spam when checking quests in Northrend set expansion to wotlk if not provided Co-Authored-By: mostlikely4r <[email protected]> Co-Authored-By: Niam5 <[email protected]>
bots enabled This is a temporary fix that just nulls the original caster pointer on the spell if the true caster is null I am unsure of why this happens with bots. Its possible that when there are active spells and a bot is deactivated or teleported, the spell is not cleaned up
alimalkhalifa
changed the title
|
Having difficulties testing this due to incompatibility between spp data and the latest binaries |
celguar
force-pushed
the
ike3-bots
branch
3 times, most recently
from
a149bfb to
137ffa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Temporary fix for crash on Spell::UpdateOriginalCasterPointer() with bots enabled
Proof
It has been running smoothly for a while. I will update and remove [WIP] tag when it has run for 24 hours
Issues
How2Test
Todo / Checklist