Make the playerbotai and playerbotmgr unique ptr

celguar · Jan 22, 2024 · 436f9c7 · 436f9c7
1 parent d4f3b27
commit 436f9c7
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/playerbot/PlayerbotMgr.cpp b/playerbot/PlayerbotMgr.cpp
@@ -226,10 +226,7 @@ void PlayerbotHolder::DisablePlayerBot(uint32 guid)
 
         if (bot->GetPlayerbotAI()) 
         {
-            {
-                delete bot->GetPlayerbotAI();
-            }
-            bot->SetPlayerbotAI(0);
+            bot->RemovePlayerbotAI();
         }
     }
 }
@@ -245,8 +242,7 @@ void PlayerbotHolder::OnBotLogin(Player * const bot)
     PlayerbotAI* ai = bot->GetPlayerbotAI();
     if (!ai)
     {
-        ai = new PlayerbotAI(bot);
-        bot->SetPlayerbotAI(ai);
+        bot->CreatePlayerbotAI();
     }
 
 	OnBotLoginInternal(bot);
@@ -826,33 +822,35 @@ list<string> PlayerbotHolder::HandlePlayerbotCommand(char const* args, Player* m
         bool hasBot = false;
 
         if (!master)
+        {
             master = GetPlayerBotsBegin()->second;
+        }
 
         PlayerbotAI* ai = master->GetPlayerbotAI();      
-
         if (ai)
+        {
             hasBot = true;
+        }
         else
         {
-            ai = new PlayerbotAI(master);
-            master->SetPlayerbotAI(ai);
+            master->CreatePlayerbotAI();
+            ai = master->GetPlayerbotAI();
             ai->SetMaster(master);
             ai->ResetStrategies();
         }
 
         command = command.substr(6);
 
         if(ai->DoSpecificAction("cdebug", Event(".bot",command,master), true))
+        {
             messages.push_back("debug failed");
+        }
 
         if (!hasBot)
         {
             if (master->GetPlayerbotAI()) 
             {
-                {
-                    delete master->GetPlayerbotAI();
-                }
-                master->SetPlayerbotAI(0);
+                master->RemovePlayerbotAI();
             }
         }