-Crash fix: When a non-randombot sends back items it sent to itself.

celguar · Dec 14, 2023 · 457b19a · 457b19a
1 parent 1acae60
commit 457b19a
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/playerbot/strategy/actions/CheckMailAction.cpp b/playerbot/strategy/actions/CheckMailAction.cpp
@@ -13,10 +13,17 @@ bool CheckMailAction::Execute(Event& event)
     bot->GetSession()->HandleQueryNextMailTime(p);   
 
     list<uint32> ids;
+
+    PlayerMails mails;
+
+    //Fetch mails first and then loop over them to prevent needing to check mails sent to self.
     for (PlayerMails::iterator i = bot->GetMailBegin(); i != bot->GetMailEnd(); ++i)
     {
-        Mail* mail = *i;
+        mails.push_back(*i);
+    }
 
+    for (auto & mail : mails)
+    {
         if (!mail || mail->state == MAIL_STATE_DELETED)
             continue;