-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve current Exception Handler #1125
base: main
Are you sure you want to change the base?
Improve current Exception Handler #1125
Conversation
This seems like a really nice feature to have! I do think that telling users to report crashing issues to GitHub is pretty risky. Generally, these (recurring) crashes are more often a user setup or game files error then anything else. We currently also have plenty of issues and don't really have enough maintainers to manage/fix even more. I think this referral should really just be to the troubleshooting channel in our discord or on our subreddit, if anything at all. I'm kinda worried that even those places will see too big of an influx in users, especially if you don't give them any tips on what they could do themselves before asking for help. The ideal solution in my opinion (also have spoken a bit about this with Exzap) is that:
|
|
Purpose
This PR aims to improve the CEMU exception handler (as a response to #1023)
Features
log.txt
to clipboardDescription
The changes spawn a thread on CafeSystem initialization that will continously read a boolean and yield if the boolean is
false
.This boolean is set to
true
if a unhandled exception occurs, shutting down CafeSystem (to avoid the game still running in the background and other synchronization issues occuring) then displaying the message boxes.Pictures