Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan: Improve post-shutdown cleanup and minor improvements #1401

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Vulkan: Improve post-shutdown cleanup and minor improvements #1401

wants to merge 26 commits into from

Commits on Nov 4, 2024

  1. Vulkan: Fix race condition validation errors

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3cff05e View commit details
    Browse the repository at this point in the history

  2. Vulkan: Fix swapchain renderpass validation errors 

    Fix validation error introduced in 1706075
Make renderpass discard previous image content and clear during renderpass instead of before
    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e09f85f View commit details
    Browse the repository at this point in the history

  3. Vulkan: Change command buffers from simultaneous use to single use 

    Possible performance improvement? Knowing that
    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b41d600 View commit details
    Browse the repository at this point in the history

  4. Renderers: Cleanup RendererOutputShaders

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    af5114d View commit details
    Browse the repository at this point in the history

  5. Vulkan: Destroy VkShaderModule objects

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2793f88 View commit details
    Browse the repository at this point in the history

  6. Vulkan: Partially(?) implement CopySurface cleanup

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4581281 View commit details
    Browse the repository at this point in the history

  7. Vulkan: Manage ownership of memory manager with unique_ptr

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d6a5693 View commit details
    Browse the repository at this point in the history

  8. Vulkan: Cleanup backbufferblit pipelines

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7dd28f7 View commit details
    Browse the repository at this point in the history

  9. Vulkan: Cleanup pipeline cache

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    df53971 View commit details
    Browse the repository at this point in the history

  10. Vulkan: Fix sampler object leak

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    721d0ce View commit details
    Browse the repository at this point in the history

  11. Vulkan: Free RingAllocator buffers upon destruction

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f2096a6 View commit details
    Browse the repository at this point in the history

  12. Vulkan: Properly free TextureChunkedHeaps

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    95c9701 View commit details
    Browse the repository at this point in the history

  13. Vulkan: Free swapchain DescriptorSetLayout

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c93858b View commit details
    Browse the repository at this point in the history

  14. Vulkan: Free command buffer semaphores

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e524e08 View commit details
    Browse the repository at this point in the history

  15. Vulkan: Fix ImGui font leak

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    16c5726 View commit details
    Browse the repository at this point in the history

  16. Vulkan: cleanup copySurface pipeline framebuffers/descriptors

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f924e13 View commit details
    Browse the repository at this point in the history

  17. Vulkan: Remove obsolete comments/vector and process destruction queue… 

    … near the end of destructor
    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d4c4c32 View commit details
    Browse the repository at this point in the history

  18. Vulkan: Cleanup backbuffer descriptor sets and pool

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    44a3c00 View commit details
    Browse the repository at this point in the history

  19. Vulkan: Proper fix for sampler leak in draw_getOrCreateDescriptorSet

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f013609 View commit details
    Browse the repository at this point in the history

  20. Vulkan: Delete superfluous DestroyFontsTexture call

    @goeiecool9999
    goeiecool9999 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7ce6ab7 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Vulkan: mark descriptor samplers on draw

    @goeiecool9999
    goeiecool9999 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    45afeaa View commit details
    Browse the repository at this point in the history

  2. Vulkan: Loop processing destruction queue until empty 

    fixes a bug where one iteration is not enough due to dependency chains.
    @goeiecool9999
    goeiecool9999 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ec91b6c View commit details
    Browse the repository at this point in the history

  3. Vulkan: destroy occlusion query pool

    @goeiecool9999
    goeiecool9999 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0866c47 View commit details
    Browse the repository at this point in the history

  4. flag samplers at more logical place, add reference from dsInfo

    @goeiecool9999
    goeiecool9999 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    de2cc13 View commit details
    Browse the repository at this point in the history

  5. deduplicate prepareDescriptorSets code

    @goeiecool9999
    goeiecool9999 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ac2b5d0 View commit details
    Browse the repository at this point in the history

  6. Fix imgui texture leak if shadercache loading is interrupted

    @goeiecool9999
    goeiecool9999 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0b559fb View commit details
    Browse the repository at this point in the history