fix(Table): Reconfigured the table CSS to better allow for content within a table to overlay the container, such as dropdowns. #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-cedrone-cengage
requested review from
silvalaura and
a team
as code owners
🦋 Changeset detectedLatest commit: 201ddf5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silvalaura
reviewed
Jan 21, 2025
There was a problem hiding this comment.
- hasSquareCorners is broken in this example: https://storybook-preview-1621--upbeat-sinoussi-f675aa.netlify.app/?path=/story/table--square-corners&args=hasSquareCorners:false
- This breaks the square corners if the dropdown item is in the last row:
<Table maxWidth={500} {...args}>
<TableHead>
<TableRow>
<TableHeaderCell>Column</TableHeaderCell>
<TableHeaderCell>Column</TableHeaderCell>
<TableHeaderCell>Column</TableHeaderCell>
<TableHeaderCell>Column</TableHeaderCell>
</TableRow>
</TableHead>
<TableBody>
<TableRow>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell>
<Dropdown isInverse={args.isInverse}>
<DropdownButton>Basic Dropdown</DropdownButton>
<DropdownContent>
<DropdownMenuItem>Menu item 1</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
</DropdownContent>
</Dropdown>
</TableCell>
</TableRow>
<TableRow>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell>
<Select
labelText="Select Example"
items={[
{ label: 'Red', value: 'red' },
{ label: 'Blue', value: 'blue' },
{ label: 'Green', value: 'green' },
{ label: 'Yellow', value: 'yellow' },
]}
isInverse={args.isInverse}
/>
</TableCell>
</TableRow>
<TableRow>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell>
<Combobox
isMulti
labelText="ComboBox Example"
defaultItems={[
{ label: 'Pink', value: 'pink' },
{ label: 'Orange', value: 'orange' },
{ label: 'Purple', value: 'purple' },
]}
isInverse={args.isInverse}
/>
</TableCell>
</TableRow> <TableRow>
<TableCell><Dropdown isInverse={args.isInverse}>
<DropdownButton>Basic Dropdown</DropdownButton>
<DropdownContent>
<DropdownMenuItem>Menu item 1</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
<DropdownMenuItem>Menu item number two</DropdownMenuItem>
</DropdownContent>
</Dropdown></TableCell>
<TableCell>Lorem ipsum dolor sit amet consectetur</TableCell>
<TableCell><Select
labelText="Select Example"
items={[
{ label: 'Red', value: 'red' },
{ label: 'Blue', value: 'blue' },
{ label: 'Green', value: 'green' },
{ label: 'Yellow', value: 'yellow' },
]}
isInverse={args.isInverse}
/></TableCell>
<TableCell>
<Combobox
isMulti
labelText="ComboBox Example"
defaultItems={[
{ label: 'Pink', value: 'pink' },
{ label: 'Orange', value: 'orange' },
{ label: 'Purple', value: 'purple' },
]}
isInverse={args.isInverse}
/>
</TableCell>
</TableRow>
</TableBody>
</Table>
Comment on lines
118
to
121
| border-radius: ${props => (props.hasSquareCorners ? '0' : '0 0 0 8px')}; | ||
| } | ||
| td:last-child { | ||
| border-radius: ${props => (props.hasSquareCorners ? '0' : '0 0 8px 0')}; |
There was a problem hiding this comment.
We should use our border radius variable
Comment on lines
88
to
93
| &:first-child { | ||
| border-radius: ${props => (props.hasSquareCorners ? '0' : '8px 0 0 0')}; | ||
| } | ||
| &:last-child { | ||
| border-radius: ${props => (props.hasSquareCorners ? '0' : '0 8px 0 0')}; | ||
| } |
There was a problem hiding this comment.
We should use our border radius variable
| 'border-radius', | ||
| magma.spaceScale.spacing03 | ||
| `${magma.spaceScale.spacing03} 0 0 0`, |
There was a problem hiding this comment.
We should use magma.borderRadius instead of the spaceScale
silvalaura
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: # 1556
What I did
Tablecontainer.Screenshots:
Checklist
How to test