fix: Repointed a few broken links and fixed some styling bugs throughout the examples. #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-cedrone-cengage
requested review from
silvalaura and
a team
as code owners
🦋 Changeset detectedLatest commit: bab5c8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closed
silvalaura
reviewed
Jan 30, 2025
silvalaura
approved these changes
Jan 31, 2025
moathabuhamad-cengage
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: # 1610
What I did
Checklist
How to test
Link 1
Verify link works: Design > Intro > Getting started > Icon
Link 2
Verify Sketch link and accompanying paragraph has been removed under: Design > Icon > Icon Resources
Link 3
Verify link works: Components > Intro > Usage > ThemeContext.Provider
Link 4
Verify link works: Components > Button > Button Group
Link 5
Verify link works: Components > Dropdown > Button Group
Link 6
Verify link works: Components > Form Group > Radio Group
Link 7
Verify link works: Components > Global Styles > ThemeContext.Provider
Link 8
Verify link works: Components > Transition > Motion.div
Transition examples
Verify the block is inside the container: Components > Transition > Nudge
Incorrect Modal
Verify focus returns to the button when closing any Modal: Components > Modal > Any
Style issue 1
Verify tooltip focus doesn't overlap text in: Components > Intro > Styles and Themes > Customization
Style issue 2
Verify keyboard focus doesn't overlap other buttons on Link inverse button: Components > Button > Inverse > Link inverse button
Style issue 3
Verify spacing between tooltip buttons: Components > Tooltip > Position > Tooltips