Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TimePicker): Fix input wrong number validation #1639

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(TimePicker): Fix input wrong number validation #1639

wants to merge 3 commits into from
+51 −15

Conversation

nikitaorliak-cengage
Copy link
Collaborator

@nikitaorliak-cengage nikitaorliak-cengage commented Jan 30, 2025 •
edited
Loading

Issue: #1517

What I did

Fix TimePicker validation.

Screenshots:

Checklist

  • changeset has been added
  • Pull request description is descriptive
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

How to test

  • Open Storybook -> TimePicker -> Replace the time with '11:59' -> Try replacing the minutes from 59 to 30 by pressing the number 3 when the minutes are selected, then 0 -> Notice that the time ends up being '30'.
  • Same for Hours -> '11:59' -> Replacing from 11 to 9 -> Notice that the time ends up being '9'.

@nikitaorliak-cengage nikitaorliak-cengage added the ready for review Pull requests that are ready for developer review label Jan 30, 2025
@nikitaorliak-cengage nikitaorliak-cengage self-assigned this Jan 30, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 48f8c6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-magma-dom Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://docs-preview-1639--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://storybook-preview-1639--upbeat-sinoussi-f675aa.netlify.app

@silvalaura silvalaura linked an issue Jan 30, 2025 that may be closed by this pull request
TimePicker: Entering a new time does not completely clear the input #1517
Open
@silvalaura silvalaura mentioned this pull request Jan 30, 2025
Closed
5 tasks
@chris-cedrone-cengage
Copy link
Collaborator

I see this bug when replicating these steps

  1. In Storybook > TimePicker
  2. Replace the time with 11:59
  3. Try replacing the minutes from 59 to 30 by pressing the number 3 when the minutes are selected, then 0
  4. Notice that the time ends up being 50

@silvalaura
Copy link
Collaborator

I see what Chris said above -- seems to depend where the cursor is placed when clicking inside the time picker.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

🚀 Deployed on https://docs-preview-1639--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

🚀 Deployed on https://storybook-preview-1639--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

🚀 Deployed on https://docs-preview-1639--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

🚀 Deployed on https://storybook-preview-1639--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

🚀 Deployed on https://docs-preview-1639--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

🚀 Deployed on https://storybook-preview-1639--upbeat-sinoussi-f675aa.netlify.app

@silvalaura silvalaura added the needs design feedback Waiting for Design approval or feedback label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvalaura silvalaura Awaiting requested review from silvalaura silvalaura is a code owner

@chris-cedrone-cengage chris-cedrone-cengage Awaiting requested review from chris-cedrone-cengage

@moathabuhamad-cengage moathabuhamad-cengage Awaiting requested review from moathabuhamad-cengage

@orion-cengage orion-cengage Awaiting requested review from orion-cengage

Assignees

@nikitaorliak-cengage nikitaorliak-cengage

Labels
needs design feedback Waiting for Design approval or feedback ready for review Pull requests that are ready for developer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TimePicker: Entering a new time does not completely clear the input
3 participants
@nikitaorliak-cengage @chris-cedrone-cengage @silvalaura