Feature/issue 13 #37
Merged
Feature/issue 13 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbitlens
requested changes
Apr 2, 2020
Centaurus.Domain/MessageHandlers/AlphaHandlers/BaseAlphaMessageHandler.cs
Show resolved
Hide resolved
| var request = envelope.Message as RequestQuantum; | ||
| if (request == null) | ||
| return; | ||
| var account = Global.AccountStorage.GetAccount(request.RequestMessage.Account); |
There was a problem hiding this comment.
This can be a minor performace problem in a future. We populate the account when the request arrives. Can we somehow obtain it from the request, without fetching from the storage?
There was a problem hiding this comment.
Let's move it to separate issue
Centaurus.Domain/Snapshot/DALModelExtensions/SettingsModelExtensions.cs
Outdated
Show resolved
Hide resolved
2 tasks
orbitlens
approved these changes
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13