Improve UX for search filters (#39) #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in the issue thread, add a vertical line to clarify that the object type filters are separate from the domain/deprecated filters. Also add a bit of text under each to explain. I also noticed that the earlier fix in storage.js was not working in the chrome extension code path, so I fixed that as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 62.23% 62.33% +0.10%
==========================================
Files 19 19
Lines 752 754 +2
Branches 116 115 -1
==========================================
+ Hits 468 470 +2
Misses 284 284 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in the issue thread, add a vertical line to clarify that the object type filters are separate from the domain/deprecated filters. Also add a bit of text under each to explain.
I also noticed that the earlier fix in storage.js was not working in the chrome extension code path, so I fixed that as well.