Skip to content

Commit

Permalink
Allow merging object with custom type under new eslint rules
Browse files Browse the repository at this point in the history
Using the spread operator on class instances will lose their class prototype  @typescript-eslint/no-misused-spread
  • Loading branch information
dpilafian committed Jan 20, 2025
1 parent 062104d commit fd2c742
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@
"hljs-enhance": "~2.0"
},
"devDependencies": {
"@eslint/js": "~9.17",
"@eslint/js": "~9.18",
"@fortawesome/fontawesome-free": "~6.7",
"@types/node": "~22.10",
"add-dist-header": "~1.4",
"assert-deep-strict-equal": "~1.2",
"copy-file-util": "~1.2",
"copy-folder-util": "~1.1",
"csso-cli": "~4.0",
"eslint": "~9.17",
"eslint": "~9.18",
"esm-to-plain-js": "~1.1",
"jshint": "~2.13",
"less": "~4.2",
Expand All @@ -102,7 +102,7 @@
"rimraf": "~6.0",
"run-scripts-util": "~1.3",
"typescript": "~5.7",
"typescript-eslint": "~8.19",
"typescript-eslint": "~8.20",
"uglify-js": "~3.19",
"w3c-html-validator": "~1.8"
}
Expand Down
2 changes: 1 addition & 1 deletion src/js/lib-x.ts
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ const libXAnimate = {
intervalMsec: 10000, //10 seconds between transitions
fadeMsec: 3000, //3 seconds to complete transition
};
const settings = { ...defaults, ...options };
const settings = { ...defaults, ...options }; //eslint-disable-line @typescript-eslint/no-misused-spread
container.classList.add('montage-loop');
if (!container.children.length)
console.error('[montage-loop] No images found:', container);
Expand Down

0 comments on commit fd2c742

Please sign in to comment.