Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-106121-gorgone-use-vault-autonomous-library #1791

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

MON-106121-gorgone-use-vault-autonomous-library #1791

wants to merge 16 commits into from

Conversation

Evan-Adam
Copy link
Contributor

Description

Add centreonvault dependancy and use it to retrieve all secret in the gorgone conf with a vault API.

Fixes # MON-106121

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

How this pull request can be tested ?

check gorgone can still be launched and correctly write it's log to the log file (start the service, check the log for any error, there should not be any)
configure vault and change one of gorgone property for a secret. The secret should be correctly retrieved from the vault.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Evan-Adam Evan-Adam force-pushed the MON-106121-gorgone-use-vault-autonomous-library branch from 66c2de2 to b9ad762 Compare October 28, 2024 17:02
@Evan-Adam Evan-Adam added the upload-artifacts force nfpm to upload every package built as an artifact label Oct 29, 2024
@Evan-Adam Evan-Adam force-pushed the MON-106121-gorgone-use-vault-autonomous-library branch from 0461adf to 14f681b Compare November 19, 2024 12:39
@Evan-Adam Evan-Adam changed the base branch from develop to MON-106121-build-centreon-perl-libs November 19, 2024 12:49
@Evan-Adam Evan-Adam force-pushed the MON-106121-gorgone-use-vault-autonomous-library branch 8 times, most recently from 74196f4 to 43e794d Compare November 26, 2024 15:04
Base automatically changed from MON-106121-build-centreon-perl-libs to develop November 26, 2024 16:46
@Evan-Adam
fix(gorgone): comment the function and code
380ba1c 
Refs:MON-106121
@Evan-Adam
tests(gorgone): Add a whole gorgone configuration to be checked by un…
c96ba15 
…it tests.

I didn't link to the template used by package installation because it can change (this have more configuration by the way) and I don't want to be sure the package install the correct file, I want to be sure gorgone read configuration correctly.

Refs:MON-106121
@Evan-Adam
tests(gorgone): finish tests of existing configuration
bbca10b 
Still need to add the vault feature and fix the tests for it, maybe add another vault jey in the big configuration
Refs:MON-106121
@Evan-Adam
feat(gorgone): interpret vault secret in gorgone configuration
500c88b 
Refs:MON-106121
@Evan-Adam
doc(gorgone): Add vault option in documentation
3b83ce0 
Refs:MON-106121
@Evan-Adam
ci(gorgone): launch gorgone build when tests are modified
c3bea24 
We need to be sure the test modified still work.

Refs:MON-106121
@Evan-Adam
feat(gorgone): Add Gorgone dependency on centreon-perl-libs-common fo…
976f65b 
…r vault.

Refs:MON-106121
@Evan-Adam
ci(gorgone): Gorgone unit test run on the CI.
1769d0f 
Refs:MON-106121
@Evan-Adam
ci(gorgone): fix unit tests
d17863d 
Refs:MON-106121
@Evan-Adam
ci(gorgone): fix cache key
1dedf95 
Refs:MON-106121
@Evan-Adam
fix(gorgone): use new common libs.
b6131f8 
Refs:MON-106121
@Evan-Adam
tests(gorgone): use gorgone log format to fix automated tests
92f8ef6 
Refs:MON-106121
@Evan-Adam
feat(gorgone): remove Gorgone specific log library
b1e81e6 
The library is now in perl-libs/lib/centreon/common/logger.pm and available from centreon-perl-libs-common package.

Refs:MON-106121
@Evan-Adam Evan-Adam force-pushed the MON-106121-gorgone-use-vault-autonomous-library branch from 3827d3c to b1e81e6 Compare November 26, 2024 16:48
@Evan-Adam Evan-Adam marked this pull request as ready for review November 26, 2024 16:48
@Evan-Adam Evan-Adam requested a review from a team as a code owner November 26, 2024 16:48
@Evan-Adam Evan-Adam requested review from a team as code owners November 26, 2024 16:48
@Evan-Adam
tests(gorgone): add more vault test in automated tests
8b3fc53 
Refs:MON-106121
@Evan-Adam
ci(gorgone): don't deliver package if test don't pass
2c1ece1 
The automated test should pass before we try to deliver the deb/rpm package. This is for now not backported because the tests are still new.

Refs:MON-106121
@Evan-Adam
doc(gorgone): add vault documentation in gorgone
f31eb5e 
Refs:MON-106121
@Evan-Adam Evan-Adam requested a review from a team as a code owner November 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucie-dubrunfaut lucie-dubrunfaut Awaiting requested review from lucie-dubrunfaut lucie-dubrunfaut is a code owner automatically assigned from centreon/owners-perl

@ddes ddes Awaiting requested review from ddes ddes is a code owner automatically assigned from centreon/owners-pipelines

@mushroomempires mushroomempires Awaiting requested review from mushroomempires mushroomempires is a code owner automatically assigned from centreon/owners-pipelines

@bouda1 bouda1 Awaiting requested review from bouda1 bouda1 is a code owner automatically assigned from centreon/owners-cpp

@smau-centreon smau-centreon Awaiting requested review from smau-centreon smau-centreon is a code owner automatically assigned from centreon/owners-doc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
upload-artifacts force nfpm to upload every package built as an artifact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Evan-Adam