Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packaging): updated naming scheme for centreon plugins perl dependencies #4867

Merged
merged 27 commits into from
Feb 1, 2024

Conversation

mushroomempires
Copy link
Contributor

@mushroomempires mushroomempires commented Jan 29, 2024

Description

fixes the packaging of perl dependencies on debian so that bullseye and bookworm generated packages do not have the same name and thus preventing one from replacing the other
currently blocking the debian 12 packaging on web since the dockerize step requires these dependencies and can only find them for one debian distribution

Fixes # MON-34667

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

N/A

How this pull request can be tested ?

running the perl dependencies workflows and checking if they are delivered with the correct name on artifactory

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@mushroomempires mushroomempires marked this pull request as ready for review January 30, 2024 15:31
@mushroomempires mushroomempires requested review from a team as code owners January 30, 2024 15:31
kduret
kduret previously approved these changes Jan 31, 2024
sc979
sc979 previously approved these changes Jan 31, 2024
.github/actions/package-nfpm/action.yml Outdated Show resolved Hide resolved
.github/actions/package-nfpm/action.yml Outdated Show resolved Hide resolved
@mushroomempires mushroomempires dismissed stale reviews from sc979 and kduret via b271fa5 January 31, 2024 15:05
@mushroomempires mushroomempires requested a review from sc979 January 31, 2024 16:29
@mushroomempires mushroomempires merged commit 7addb5a into develop Feb 1, 2024
51 checks passed
@mushroomempires mushroomempires deleted the MON-34667-naming-scheme-debian-packages branch February 1, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants