Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(centreon-vault): move vault lib to it's own package MON-106121 #5224

Closed

Conversation

Evan-Adam
Copy link
Contributor

Refs:MON-106121

Description

Move centreonvault.pm to it's own library to be used by centreon-gorgone and the actual centreon_vmware.

Fixes # MON-106121

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

launch the centreon_vmware daemon with a vault correctly configured, it should still work the same as before.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@Evan-Adam Evan-Adam force-pushed the MON-106121-gorgone-use-vault-autonomous-library branch 3 times, most recently from 2509d15 to 60bc692 Compare October 15, 2024 15:01
…severity options.

These numbers should be only internal.
added warning and notice severity to manage more finely gorgone logs in the future.
Added flush_output for gorgone which enable it by default

Refs:MON-106121
these test use test2::V0, but are not set up in the CI for now, this lib is not packaged for debian.

Refs:MON-106121
@Evan-Adam Evan-Adam force-pushed the MON-106121-gorgone-use-vault-autonomous-library branch from 60bc692 to 792d077 Compare October 15, 2024 15:04
@Evan-Adam
Copy link
Contributor Author

I found centreon-perl-libs package, so this is moved to centreon/centreon repo :
centreon/centreon#5483
#5265 # allow the unit test to run for centreonvault and gorgone.

@Evan-Adam Evan-Adam closed this Oct 29, 2024
@garnier-quentin
Copy link
Contributor

@Evan-Adam why you don't use https://metacpan.org/pod/CryptX module (instead of Openssl AES) ?

The CryptX module is used everywhere (gorgone,...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants