Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vmware-daemon): fix the case-sensitiveness regression on containers #5247

Conversation

omercier
Copy link
Contributor

Description

Fixed a regression when container names were declared with capital letters.

  • A regression had occurred during the introduction of the support JSON formatted configuration files. The previous behaviour is restored: container keys are case insensitive.
  • Error log messages related to Centreon Vault have been downgraded or relativised.

Refs: CTOR-1005

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

- A regression had occurred during the introduction of the support JSON
  formatted configuration files. The previous behaviour is restored: container keys are case insensitive.
- Error log messages related to Centreon Vault have been downgraded or
  relativised.
@omercier omercier merged commit 2ceae20 into hotfix-20241018 Oct 18, 2024
9 checks passed
@omercier omercier deleted the CTOR-1005-HOTFIX-container-names-in-centreon-vmware-pm-are-now-case-sensitive branch October 18, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants