Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure-elasticpool): the thresholds weren't applied correctly in storage mode #5294

Conversation

omercier
Copy link
Contributor

@omercier omercier commented Nov 19, 2024

Description

Fixed the storage mode: bad definition for custom_metric_threshold and custom_metric_perfdata subs.

Refs: CTOR-858

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@omercier omercier changed the title fix(azure-elasticpool): the thresholds were'nt applied correctly fix(azure-elasticpool): the thresholds were'nt applied correctly in storage mode Nov 19, 2024
@omercier omercier force-pushed the CTOR-858-Plugin-cloud-azure-database-elasticpool-Mode-storage-Thresholds-not-taken-into-account branch from 2e764c9 to 2b71cce Compare November 19, 2024 15:54
@omercier omercier marked this pull request as ready for review November 19, 2024 15:58
@omercier omercier requested review from a team as code owners November 19, 2024 15:58
@omercier omercier changed the title fix(azure-elasticpool): the thresholds were'nt applied correctly in storage mode fix(azure-elasticpool): the thresholds weren't applied correctly in storage mode Nov 22, 2024
@omercier omercier merged commit 9cee927 into develop Nov 22, 2024
25 checks passed
@omercier omercier deleted the CTOR-858-Plugin-cloud-azure-database-elasticpool-Mode-storage-Thresholds-not-taken-into-account branch November 22, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants