add new sdk to current app #2579

kattylucy · 2025-01-16T09:57:21Z

Integrate new sdk into out current app (reports and data tabs only)

Dev

github-actions · 2025-01-27T11:28:12Z

PR deployed in Google Cloud
URL: https://app-pr2579.k-f.dev
Commit #: 7191f80
To access the functions directly check the corresponding deploy Action

github-actions · 2025-01-27T11:30:14Z

PR deployed in Google Cloud
URL: https://pr2579-app-ff-production.k-f.dev
Commit #: 7191f80
To access the functions directly check the corresponding deploy Action

socket-security · 2025-01-28T10:26:17Z

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

sophialittlejohn · 2025-02-04T14:27:42Z

centrifuge-app/src/utils/formatting.ts

+
+// FORMAT FUNCTIONS FOR NEW SDK
+
+export function formatDecimal(decimalVal: any, displayDecimals: number, currency?: string): string {


Suggested change

export function formatDecimal(decimalVal: any, displayDecimals: number, currency?: string): string {

export function formatDecimal( amount: CurrencyBalance | TokenBalance | Price | Rate | Decimal | number,

, displayDecimals = 2, currency?: string): string {

Would love to see this function types like the other formatting options we had. There will be some type conflicts with Rate/Perquintill but I think you can circumvent the problem by writing the functions in a new file e.g formatting-sdk.ts. Then we can likely also keep the names formatBalance, formatBalanceAbbreviated and formatPercentage (I don't think formatDecimal really conveys what the function does)

sophialittlejohn · 2025-02-07T14:15:57Z

centrifuge-app/package.json

@@ -29,7 +29,7 @@
    "@centrifuge/centrifuge-js": "workspace:*",
    "@centrifuge/centrifuge-react": "workspace:*",
    "@centrifuge/fabric": "workspace:*",
-    "@centrifuge/sdk": "^0.0.0-alpha.0",
+    "@centrifuge/sdk": "latest",


Let's pin down the version so we don't accidentally include updates that we're not ready for yet

sophialittlejohn · 2025-02-07T14:27:45Z

centrifuge-app/src/components/Report/FeeTransactions.tsx

+      ?.filter(
+        (tx) => tx.transactionType !== 'PROPOSED' && tx.transactionType !== 'ADDED' && tx.transactionType !== 'REMOVED'
+      )


could we move this filter to the sdk?

Move filter to sdk and specify the sdk version

sophialittlejohn

Amazing!!! 🔥🔥🔥

Let's get this merged after this current release to give product enough time to test it before it goes live

kattylucy · 2025-02-12T04:46:35Z

No problem. I will merge it into your reports branch and we can release from there!

* Use Centrifuge SDK in cashflow report * Remove unused cashflow chart files * Fix asset purchases/asset financings * Use first offical alpha release of sdk * add new sdk to current app (#2579) * Upgrade SDK * Add hook * Add formatting and utils * Add to reports * wip[ * Fix bugs based on new sdk release * Add reports to query * Remove console * Fix formatting options * Fix imports * Fix formatting * Fix percentage function * Feedback changes Move filter to sdk and specify the sdk version * fix bug on report type --------- Co-authored-by: Guillermo Perez <[email protected]> Co-authored-by: Katty Barroso <[email protected]>

* ci: Review GHA pipeline (#2620) * upgrade 3rd party action versions and configure dependabot * remove catalyst and cleanup unused functions deployments * Make sure prod deploy uses the right tag to pull artifacts * Adding more owners for bus factor purposes * Simplify and fix prod deploy to allow for rollbacks * notify slack of staging failed jobs * upgrade node to v20 (v18 deprecated in April) * disable e2e tests automatic triggers * Improve PR comment adding the functions URL --------- Co-authored-by: sophian <[email protected]> * Redemption flow fixes (#2626) - Change logic around the redeem flow - Remove rounded number from clain button * Use new Centrifuge SDK in cashflow report (#2549) * Use Centrifuge SDK in cashflow report * Remove unused cashflow chart files * Fix asset purchases/asset financings * Use first offical alpha release of sdk * add new sdk to current app (#2579) * Upgrade SDK * Add hook * Add formatting and utils * Add to reports * wip[ * Fix bugs based on new sdk release * Add reports to query * Remove console * Fix formatting options * Fix imports * Fix formatting * Fix percentage function * Feedback changes Move filter to sdk and specify the sdk version * fix bug on report type --------- Co-authored-by: Guillermo Perez <[email protected]> Co-authored-by: Katty Barroso <[email protected]> * Fix bug on pool creation demo (#2629) * Take stepper outside form context * Fix infinite loop bug * Hide scrolling on menu bar (#2631) * Fix token amount calculation (#2634) * Persist to, from and groupBy filters and fix linter warnings (#2635) --------- Co-authored-by: Guillermo Perez <[email protected]> Co-authored-by: Katty Barroso <[email protected]>

kattylucy changed the base branch from main to reports January 16, 2025 09:57

kattylucy force-pushed the sdk_add_reports_to_app branch 4 times, most recently from 93d40a5 to 1111dff Compare January 24, 2025 10:21

kattylucy force-pushed the sdk_add_reports_to_app branch from 53a9371 to a176b8c Compare January 27, 2025 19:02

kattylucy added 3 commits January 27, 2025 20:04

Upgrade SDK

8c87ee9

Add hook

76e7a46

Add formatting and utils

20e6a86

kattylucy force-pushed the sdk_add_reports_to_app branch from fc5a202 to 3b36d12 Compare January 27, 2025 19:05

kattylucy force-pushed the sdk_add_reports_to_app branch from 8336c18 to 7dff8d0 Compare January 28, 2025 10:28

Add to reports

3fe9057

kattylucy force-pushed the sdk_add_reports_to_app branch from d69f969 to 3fe9057 Compare January 28, 2025 15:53

kattylucy added 4 commits January 29, 2025 12:01

wip[

f480590

Fix bugs based on new sdk release

9e4fe72

Add reports to query

cb051a6

Remove console

c2e3556

kattylucy force-pushed the sdk_add_reports_to_app branch from 89d04b6 to c2e3556 Compare February 4, 2025 09:06

kattylucy marked this pull request as ready for review February 4, 2025 09:06

kattylucy requested a review from sophialittlejohn February 4, 2025 09:06

sophialittlejohn reviewed Feb 4, 2025

View reviewed changes

kattylucy added 4 commits February 5, 2025 11:16

Fix formatting options

ed1fbb5

Fix imports

9e8efb2

Fix formatting

7777aa9

Fix percentage function

58946d3

sophialittlejohn reviewed Feb 7, 2025

View reviewed changes

Feedback changes

7cc117f

Move filter to sdk and specify the sdk version

kattylucy requested a review from sophialittlejohn February 10, 2025 10:04

fix bug on report type

7191f80

sophialittlejohn approved these changes Feb 10, 2025

View reviewed changes

kattylucy merged commit 3891d33 into reports Feb 12, 2025
12 checks passed

kattylucy deleted the sdk_add_reports_to_app branch February 12, 2025 04:46

sophialittlejohn mentioned this pull request Feb 17, 2025

Hotxfix: PR without dashboard (#2638) #2639

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add new sdk to current app #2579

add new sdk to current app #2579

kattylucy commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

socket-security bot commented Jan 28, 2025 •

edited

Loading

sophialittlejohn Feb 4, 2025

sophialittlejohn Feb 7, 2025

sophialittlejohn Feb 7, 2025

sophialittlejohn left a comment

kattylucy commented Feb 12, 2025


		// FORMAT FUNCTIONS FOR NEW SDK

		export function formatDecimal(decimalVal: any, displayDecimals: number, currency?: string): string {

	export function formatDecimal(decimalVal: any, displayDecimals: number, currency?: string): string {
	export function formatDecimal( amount: CurrencyBalance \| TokenBalance \| Price \| Rate \| Decimal \| number,
	, displayDecimals = 2, currency?: string): string {

add new sdk to current app #2579

add new sdk to current app #2579

Conversation

kattylucy commented Jan 16, 2025 • edited Loading

github-actions bot commented Jan 27, 2025 • edited Loading

github-actions bot commented Jan 27, 2025 • edited Loading

socket-security bot commented Jan 28, 2025 • edited Loading

sophialittlejohn Feb 4, 2025

Choose a reason for hiding this comment

sophialittlejohn Feb 7, 2025

Choose a reason for hiding this comment

sophialittlejohn Feb 7, 2025

Choose a reason for hiding this comment

sophialittlejohn left a comment

Choose a reason for hiding this comment

kattylucy commented Feb 12, 2025

kattylucy commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

socket-security bot commented Jan 28, 2025 •

edited

Loading