Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: investor page #2609

Merged
merged 61 commits into from
Feb 14, 2025
Merged

Dashboard: investor page #2609

merged 61 commits into from
Feb 14, 2025

Conversation

sophialittlejohn
Copy link
Collaborator

@sophialittlejohn sophialittlejohn commented Feb 3, 2025

Description

This pull request...

#2586

Approvals

  • Dev

Screenshots

Impact

Copy link

github-actions bot commented Feb 3, 2025

PR deployed in Google Cloud
URL: https://pr2609-app-ff-production.k-f.dev
PINNING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/pinning-api-pr2609
ONBOARDING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/onboarding-api-pr2609
Commit #: 1de17cc

Copy link

github-actions bot commented Feb 3, 2025

PR deployed in Google Cloud
URL: https://app-pr2609.k-f.dev
PINNING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/pinning-api-pr2609
ONBOARDING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/onboarding-api-pr2609
Commit #: 1de17cc

@sophialittlejohn sophialittlejohn marked this pull request as ready for review February 12, 2025 23:28
Comment on lines 46 to 63
const data: InvestorTableRow[] = [
{
wallet: '0x423420Ae467df6e90291fd0252c0A8a637C1e03f',
trancheId: '0xc4bbcd7f0ad814f2625b93561a6ca3c1',
network: 11155111,
poolId: '1464125771',
tokenName: 'USDC',
poolCurrency: 'USDC',
poolIcon: null,
holdings: new CurrencyBalance(100, 6),
pendingInvestments: new CurrencyBalance(10000, 6),
pendingRedemptions: new CurrencyBalance(100, 6),
investorSince: '2025-02-12',
unrealizedProfit: new CurrencyBalance(100, 6),
realizedProfit: new CurrencyBalance(100, 6),
investorId: '0x423420Ae467df6e90291fd0252c0A8a637C1e03f-0xc4bbcd7f0ad814f2625b93561a6ca3c1-11155111',
},
]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove before merging, this is just so it can be seen on demo since the demo subquery isn't operational

Copy link
Collaborator

@kattylucy kattylucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!!! Few other things I noticed

  • The accordion has too much padding in the title area
  • On the table, the top right number [number] Investors, have a weird shape when 0, is not circular. You can use this instead to make it circular in all cases, it was a bit tricky for me as well.
  <Box
            background={theme.colors.backgroundTertiary}
            borderRadius="50%"
            display="flex"
            alignItems="center"
            justifyContent="center"
            width="28px"
            height="28px"
            style={{ fontWeight: 500, fontSize: 12 }}
            mr={1}
          >
            {filters.data.length}
          </Box>

          <Text variant="heading4">Assets</Text>
        </Box>

Copy link
Collaborator

@kattylucy kattylucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! good job!!

@sophialittlejohn sophialittlejohn enabled auto-merge (squash) February 14, 2025 15:33
@sophialittlejohn sophialittlejohn merged commit eba552e into main Feb 14, 2025
8 checks passed
@sophialittlejohn sophialittlejohn deleted the dashboard-investor-page branch February 14, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants