Skip to content

Commit

Permalink
Dockerfile: Switching from MAINTAINER to LABEL.
Browse files Browse the repository at this point in the history
As per https://docs.docker.com/engine/reference/builder/#/maintainer-deprecated,

MAINTAINER <name> should be replaced by LABEL maintainer="name".

This patch replace "MAINTAINER" inside the Dockerfile (daemon & daemon-base) by a "LABEL maintainer" entry in __DOCKERFILE_TRACEABILITY_LABELS__

Signed-off-by: Erwan Velu <[email protected]>
(cherry picked from commit 6373c6a)
Signed-off-by: Sébastien Han <[email protected]>
  • Loading branch information
Erwan Velu authored and leseb committed Aug 16, 2018
1 parent 7c0cb7d commit c03b12c
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ceph-releases/ALL/opensuse/__DOCKERFILE_MAINTAINER__
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Blaine Gardner "[email protected]"
Blaine Gardner <[email protected]>
1 change: 1 addition & 0 deletions ceph-releases/ALL/rhel7/__DOCKERFILE_MAINTAINER__
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Erwan Velu <[email protected]>
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,3 @@ LABEL description="Red Hat Ceph Storage 3"
LABEL summary="Provides the latest Red Hat Ceph Storage 3 on RHEL 7 in a fully featured and supported base image."
LABEL io.k8s.display-name="Red Hat Ceph Storage 3 on RHEL 7"
LABEL io.openshift.tags="rhceph ceph"
LABEL maintainer="Erwan Velu <[email protected]>"
3 changes: 3 additions & 0 deletions src/__DOCKERFILE_TRACEABILITY_LABELS__
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Who is the maintainer ?
LABEL maintainer="__DOCKERFILE_MAINTAINER__"

# What is the actual release ? If not defined, this equals the git branch name
LABEL RELEASE="__ENV_[RELEASE]__"

Expand Down
1 change: 0 additions & 1 deletion src/daemon-base/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# CEPH DAEMON BASE IMAGE

FROM __ENV_[BASE_IMAGE]__
MAINTAINER __DOCKERFILE_MAINTAINER__

__DOCKERFILE_TRACEABILITY_LABELS__

Expand Down
1 change: 0 additions & 1 deletion src/daemon/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# CEPH DAEMON IMAGE

FROM __ENV_[DAEMON_BASE_IMAGE]__
MAINTAINER __DOCKERFILE_MAINTAINER__

__DOCKERFILE_TRACEABILITY_LABELS__

Expand Down

0 comments on commit c03b12c

Please sign in to comment.