Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kube-rbac-proxy container from deployment #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Oct 15, 2024

csi-operator is not exporting any metrics exclusively and orchestrated csi already exports metrics on it's own which isn't tunneled through the operator.

kube-rbac-proxy prominently used to authenticate api access to metrics endpoint available on operator (manager) which isn't mandatory for us and this commit removes the same.

note that controller-runtime itself exports some metrics and this commit doesn't bind any port for controller-runtime which disables inbuilt metrics being available.

ref: https://book.kubebuilder.io/reference/metrics-reference

fixes: #119

csi-operator is not exporting any metrics exclusively and orchestrated
csi already exports metrics on it's own which isn't tunneled through
the operator.

kube-rbac-proxy prominently used to authenticate api access to metrics
endpoint available on operator (manager) which isn't mandatory for us
and this commit removes the same.

note that controller-runtime itself exports some metrics and this commit
doesn't bind any port for controller-runtime which disables inbuilt
metrics being available.

https://book.kubebuilder.io/reference/metrics-reference

Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg
Copy link
Contributor Author

leelavg commented Oct 15, 2024

Testing:

> k logs ceph-csi-operator-controller-manager-7d64d95794-ww4jb --since 1m | tail -n3
2024-10-15T05:09:18Z    INFO    Starting workers        {"controller": "clientprofile", "controllerGroup": "csi.ceph.io", "controllerKind": "ClientProfile", "worker count": 1}
2024-10-15T05:09:18Z    INFO    Starting workers        {"controller": "clientprofilemapping", "controllerGroup": "csi.ceph.io", "controllerKind": "ClientProfileMapping", "worker count": 1}
2024-10-15T05:09:18Z    INFO    Starting workers        {"controller": "driver", "controllerGroup": "csi.ceph.io", "controllerKind": "Driver", "worker count": 1}

@nb-ohad
Copy link
Collaborator

nb-ohad commented Oct 15, 2024

@leelavg @Madhu-1 I would prefer if we would not just remove the code and configuration but make it optional. I can predict that very soon we will need to reintroduce this to support custom metrics.

@nb-ohad
Copy link
Collaborator

nb-ohad commented Oct 15, 2024

/hold

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 22, 2024

I can predict that very soon we will need to reintroduce this to support custom metrics.

@nb-ohad can you please provide details about it?

@leelavg
Copy link
Contributor Author

leelavg commented Dec 3, 2024

If we can update the kube builder layout to 4.1.0 we can remove the kube-rbac-proxy altogether as per https://book.kubebuilder.io/reference/metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove decprecation warning from logs
3 participants