Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disk owner access fail #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix disk owner access fail #212

wants to merge 1 commit into from

Conversation

kevinzs2048
Copy link
Contributor

Fix #211

@kevinzs2048
Fix disk owner access fail
5b9cb88 
Signed-off-by: Kevin Zhao <[email protected]>
@kevinzs2048
Copy link
Contributor Author

@dillaman ping for review, thanks!

dillaman
dillaman reviewed Aug 27, 2020
View reviewed changes
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- but do you know how the system actually gets into the bad state where a LUN has no owner? It seems like we should also fix that to ensure it's an atomic operation to map the lun and assign the owner if it doesn't have one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillaman dillaman dillaman left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restart rbd-target-api failed when disk does not have owner
2 participants
@kevinzs2048 @dillaman