Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default block size in create_bdev CLI to 512 instead of 4K. #234

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Set default block size in create_bdev CLI to 512 instead of 4K. #234

merged 1 commit into from
Sep 19, 2023

Conversation

gbregman
Copy link
Collaborator

Fixes #224

@gbregman gbregman requested a review from pcuzner September 18, 2023 16:15
@gbregman gbregman changed the title Set default block size in crewate_bdev CLI to 512 instead of 4K. Set default block size in create_bdev CLI to 512 instead of 4K. Sep 18, 2023
pcuzner
pcuzner approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@pcuzner pcuzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gbregman gbregman merged commit 6d9109a into ceph:devel Sep 19, 2023
@rahullepakshi rahullepakshi mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcuzner pcuzner pcuzner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bdev sector size should default to a value that is more widely acceptable
2 participants
@gbregman @pcuzner