Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lock for GRPC calls to prevent corruption and exceptions on gateway restart #258

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

gbregman
Copy link
Contributor

Fixes #255

@gbregman gbregman requested review from oritwas, baum and caroav October 10, 2023 13:47
control/grpc.py Outdated Show resolved Hide resolved
control/server.py Outdated Show resolved Hide resolved
control/server.py Outdated Show resolved Hide resolved
control/server.py Outdated Show resolved Hide resolved
control/server.py Outdated Show resolved Hide resolved
@baum
Copy link
Collaborator

baum commented Oct 10, 2023

Fixes #255

If this problem can be reliably reproduced, it would be beneficial to consider adding a test case to showcase that the issue has been resolved.

@gbregman gbregman requested review from caroav and removed request for oritwas and caroav October 10, 2023 19:48
@gbregman gbregman force-pushed the devel branch 3 times, most recently from ac835aa to f8b147d Compare October 11, 2023 09:46
@gbregman gbregman requested review from baum, oritwas and caroav October 11, 2023 13:09
control/server.py Outdated Show resolved Hide resolved
control/server.py Outdated Show resolved Hide resolved
@gbregman gbregman requested a review from baum October 11, 2023 15:48
control/server.py Outdated Show resolved Hide resolved
control/grpc.py Outdated Show resolved Hide resolved
control/grpc.py Show resolved Hide resolved
@gbregman gbregman force-pushed the devel branch 3 times, most recently from 664474c to 086caaf Compare October 15, 2023 15:46
Copy link
Collaborator

@baum baum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

control/grpc.py Outdated Show resolved Hide resolved
tests/test_grpc.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Gateway fails to load subsystems upon nvmeof service restart
3 participants