-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lock for GRPC calls to prevent corruption and exceptions on gateway restart #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baum
reviewed
Oct 10, 2023
If this problem can be reliably reproduced, it would be beneficial to consider adding a test case to showcase that the issue has been resolved. |
gbregman
requested review from
caroav
and removed request for
oritwas and
caroav
October 10, 2023 19:48
gbregman
force-pushed
the
devel
branch
3 times, most recently
from
October 11, 2023 09:46
ac835aa
to
f8b147d
Compare
baum
reviewed
Oct 11, 2023
baum
reviewed
Oct 11, 2023
oritwas
reviewed
Oct 12, 2023
gbregman
force-pushed
the
devel
branch
2 times, most recently
from
October 15, 2023 09:41
586d3bb
to
052374e
Compare
gbregman
force-pushed
the
devel
branch
3 times, most recently
from
October 15, 2023 15:46
664474c
to
086caaf
Compare
…eway restart. Fixes ceph#255 Signed-off-by: Gil Bregman <[email protected]>
baum
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255