Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid code duplication when connecting to Rados. #292

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Avoid code duplication when connecting to Rados. #292

merged 1 commit into from
Oct 25, 2023

Conversation

gbregman
Copy link
Contributor

Fixes #289

@gbregman gbregman self-assigned this Oct 25, 2023
@gbregman gbregman requested a review from baum October 25, 2023 13:35
baum
baum approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@baum baum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🖖

@gbregman gbregman merged commit 4e7b0c7 into ceph:devel Oct 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baum baum baum approved these changes

Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate code duplication in discovery service when connecting to Rados
2 participants
@gbregman @baum