Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch SPDK exceptions in Prometheus #667

Merged
merged 1 commit into from
May 22, 2024
Merged

Catch SPDK exceptions in Prometheus #667

merged 1 commit into from
May 22, 2024

Conversation

gbregman
Copy link
Collaborator

Fixes #666

@gbregman gbregman requested a review from pcuzner May 22, 2024 13:57
@gbregman gbregman self-assigned this May 22, 2024
pcuzner
pcuzner approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@pcuzner pcuzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If time permits, fixing the flake8 issue would be good.

@gbregman gbregman merged commit 103e718 into ceph:devel May 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcuzner pcuzner pcuzner approved these changes

Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not crash Prometheus in case of an SPDK error
2 participants
@gbregman @pcuzner