package: upgrade eleventy #790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizamial09
force-pushed
the
update-eleventy
branch
2 times, most recently
from
1d69d6a to
89750cd
Compare
Generated the package-lock using node 18 and didn't see any major issue there. Following the eleventy upgrade helper to take care of the upgrade: https://www.11ty.dev/docs/plugins/upgrade-help/ Only notice the upgrade helper pointed out which is valid for us is the transition from `slug` to `slugify`. But they disregarded this as an optional because `slug` will continue to work for universal filter https://www.11ty.dev/docs/filters/slugify/#changing-slug-to-slugify ``` @11ty/eleventy-upgrade-help] NOTICE `slug` to `slugify` filter mismatches found. No action is strictly required here, but if this site has been published publicly make sure that you continue to use the `slug` filter for these templates or your public facing URLs will change/break! 'anitab.org' Expected values to be strictly equal: + actual - expected + 'anitab.org' - 'anitab-org' ^ 'wcag2.1' Expected values to be strictly equal: + actual - expected + 'wcag2.1' - 'wcag2-1' ^ "Fira Barcelona Gran Via, Av. Joan Carles I, 64, 08908 L'Hospitalet de Llobregat, Barcelona, Spain-Barcelona, Spain" Expected values to be strictly equal: + actual - expected + "fira-barcelona-gran-via-av.-joan-carles-i-64-08908-l'hospitalet-de-llobregat-barcelona-spain-barcelona-spain" - 'fira-barcelona-gran-via-av-joan-carles-i-64-08908-l-hospitalet-de-llobregat-barcelona-spain-barcelona-spain' 'undefined-https://meet.jit.si/ceph-user-dev-monthly' Expected values to be strictly equal: + actual - expected + 'undefined-https:meet.jit.siceph-user-dev-monthly' - 'undefined-https-meet-jit-si-ceph-user-dev-monthly' ^ 'null-CERN | Geneva, Switzerland' Expected values to be strictly equal: + actual - expected + 'null-cern-or-geneva-switzerland' - 'null-cern-geneva-switzerland' ^ ``` Signed-off-by: Nizamudeen A <[email protected]>
nizamial09
force-pushed
the
update-eleventy
branch
from
89750cd to
6307697
Compare
|
I generated the package files using node 23. I also updated the jenkins job (temporarily) to run with an updated node.js version. The latest I could find on debian is 20.x. I am updating the build script officially here: ceph/ceph-build#2320 https://jenkins.ceph.com/job/ceph-website-prs/1118/consoleFull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the eleventy upgrade helper to take care of the upgrade: https://www.11ty.dev/docs/plugins/upgrade-help/
Upgrade to eleventy@1
Generated the package-lock using node 18 and didn't see any major issue
there.
Only notice the upgrade helper pointed out which is valid for us is the
transition from
slugtoslugify. But they disregarded this as anoptional because
slugwill continue to work for universal filterhttps://www.11ty.dev/docs/filters/slugify/#changing-slug-to-slugify
Upgrade to eleventy@2
Major change:
The default dev server is now Eleventy Dev Server https://www.11ty.dev/docs/dev-server/.
But we still can use the BrowserSync as they stated in the doc
https://www.11ty.dev/docs/dev-server/#swap-back-to-browsersync