Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocksdb-resharding: add a retry/until (backport #107) #253

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 23, 2023

This is an automatic backport of pull request #107 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

When retrieving the container_image, if the corresponding OSD
isn't running (not started/ready yet), let's retry during 120sec before
we let the playbook fail.

This is because of a failure seen in the CI like following:

```
TASK [get container image currently used by osd container] *********************
task path: /home/jenkins-build/build/workspace/cephadm-ansible-prs-el8-functional/rocksdb-resharding.yml:66
Monday 13 June 2022  15:20:38 +0000 (0:00:00.015)       0:00:00.683 ***********
ok: [localhost -> ceph-node0] => changed=false
  cmd:
  - cephadm
  - shell
  - ceph
  - orch
  - ps
  - --daemon_type
  - osd
  - --daemon_id
  - '0'
  - --format
  - json
  delta: '0:00:02.669373'
  end: '2022-06-13 15:20:42.149214'
  rc: 0
  start: '2022-06-13 15:20:39.479841'
  stderr: |-
    Inferring fsid 4217f198-b8b7-11eb-941d-5254004b7a69
    Inferring config /var/lib/ceph/4217f198-b8b7-11eb-941d-5254004b7a69/mon.ceph-node0/config
    Using ceph image with id '7d10b4103611' and tag 'master' created on 2022-05-23 21:52:02 +0000 UTC
    quay.ceph.io/ceph-ci/ceph@sha256:0ece388ce186bf2122eb4f3389d6b108fa94aa3541d40d08449286fffc34e29f
  stderr_lines: <omitted>
  stdout: |2-

    [{"daemon_id": "0", "daemon_name": "osd.0", "daemon_type": "osd", "events": ["2022-06-13T15:20:20.821851Z daemon:osd.0 [INFO] \"Deployed osd.0 on host 'ceph-node4'\""], "hostname": "ceph-node4", "is_active": false, "memory_request": 4294967296, "ports": [], "service_name": "osd.osd", "status": 2, "status_desc": "starting"}]
  stdout_lines: <omitted>
```

We can see the 'status_desc' is 'starting'.

Signed-off-by: Guillaume Abrioux <[email protected]>
(cherry picked from commit 5743d5b)
@asm0deuz
Copy link
Collaborator

jenkins test el8-functional

@asm0deuz asm0deuz merged commit 1506bd2 into reef Nov 23, 2023
9 checks passed
@asm0deuz asm0deuz deleted the mergify/bp/reef/pr-107 branch November 23, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants