cephadm-bootstrap: add missing options to module #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asm0deuz
changed the title
asm0deuz
force-pushed
the
bz2246266_bootstrap_config
branch
6 times, most recently
from
205f5a3 to
a3f759e
Compare
guits
reviewed
Feb 5, 2024
guits
reviewed
Feb 5, 2024
guits
reviewed
Feb 5, 2024
asm0deuz
force-pushed
the
bz2246266_bootstrap_config
branch
18 times, most recently
from
c5a68a5 to
ee28451
Compare
asm0deuz
force-pushed
the
bz2246266_bootstrap_config
branch
7 times, most recently
from
34e9fa6 to
d58d65b
Compare
All existing 'cephadm bootstrap' options were not available in the cephadm-boostrap module. Added xtra_opt_cli parameter to list additional parameters Added shebang and coding information to all modules as advised by(1) (1) https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2246266 Signed-off-by: Teoman ONAY <[email protected]>
asm0deuz
force-pushed
the
bz2246266_bootstrap_config
branch
from
d58d65b to
78e9793
Compare
asm0deuz
changed the title
guits
approved these changes
Feb 13, 2024
This was referenced Feb 13, 2024
asm0deuz
added a commit
that referenced
this pull request
Feb 13, 2024
cephadm-bootstrap: add missing options to module (backport #270)
asm0deuz
added a commit
that referenced
this pull request
Feb 13, 2024
cephadm-bootstrap: add missing options to module (backport #270)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All existing 'cephadm bootstrap' options were not available in the cephadm-boostrap module. Added xtra_opt_cli parameter to list additional parameters
Added shebang and coding information to all modules as advised by(1)
(1) https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2246266