Add config option for enabling the TCP_NODELAY option on client sockets. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/23761 (cherry picked from commit b1d0f8d) Signed-off-by: Matt Benjamin <[email protected]>
oritwas
approved these changes
Apr 17, 2018
|
(that was a pass) |
|
the default is still a disable tcp_nodelay? Maybe we should override this in rgw frontend to enable this ?(also this config is already a part of luminous/master civetweb) |
|
If the RGW devs agree (which it looks they already have), I am in favor of merging this and advancing the SHA1 of the civetweb submodule for jewel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/23761
(cherry picked from commit b1d0f8d)
Signed-off-by: Matt Benjamin [email protected]