fix auth domain check for absolute uri #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks correct and will apply to master and mimic branches |
theanalyst
approved these changes
Dec 13, 2018
theanalyst
requested changes
Dec 13, 2018
There was a problem hiding this comment.
Can you actually cherry-pick with an -x argument and cherry-pick the pr civetweb#540 instead (changes in the comment line)
|
I've lost my branch for that PR, so can't update it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server close connection if request has absolute uri and "enable auth domain check" config option is disabled.
I suggest to use correct get_rel_url_at_current_server function from civetweb upstream.