Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rados: skip TestPingMonitor test #920

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

ansiwen
Copy link
Collaborator

@ansiwen ansiwen commented Sep 21, 2023

This disables the TestPingMonitor until #921 is fixed.

@ansiwen ansiwen marked this pull request as draft September 21, 2023 15:05
@ansiwen ansiwen force-pushed the pr/ansiwen/skip-pungmonitor branch from e3d729c to 305b88e Compare September 21, 2023 19:00
Related to: #921

Signed-off-by: Sven Anderson <[email protected]>
@ansiwen ansiwen force-pushed the pr/ansiwen/skip-pungmonitor branch from 60a9e46 to 1c63ec4 Compare September 25, 2023 13:29
@ansiwen ansiwen marked this pull request as ready for review September 25, 2023 13:29
@ansiwen ansiwen added the no-API This PR does not include any changes to the public API of a go-ceph package label Sep 25, 2023
@@ -114,7 +114,7 @@ func (suite *RadosTestSuite) TearDownSuite() {
}

func TestVersion(t *testing.T) {
var major, minor, patch = Version()
major, minor, patch := Version()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is because of my automatic gofmt.

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, for now.

@mergify mergify bot merged commit 9408dd5 into master Sep 25, 2023
15 checks passed
@mergify mergify bot deleted the pr/ansiwen/skip-pungmonitor branch September 25, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants