teuthology/scrape.py: Remove empty string in _get_service_types

Problem: the function grep returns a list contianing empty string which results in scrape.py throwing the warning "Misunderstood line: ". Solution: filter out empty strings before getting match with regex. Signed-off-by: Kamoltat Sirivadhna <[email protected]>
ceph · Sep 6, 2023 · 9d66ef6 · 9d66ef6
1 parent 54e62bc
commit 9d66ef6
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/teuthology/scrape.py b/teuthology/scrape.py
@@ -410,7 +410,9 @@ def _get_service_types(self, job):
         result = defaultdict(list)
         # Lines like:
         # 2014-08-22T20:07:18.668 ERROR:tasks.ceph:saw valgrind issue   <kind>Leak_DefinitelyLost</kind> in /var/log/ceph/valgrind/osd.3.log.gz
-        for line in grep(os.path.join(job.path, "teuthology.log"), "</kind> in "):
+        valgrind_err_line = grep(os.path.join(job.path, "teuthology.log"), "</kind> in ")
+        valgrind_err_line = list(filter(None, valgrind_err_line))
+        for line in valgrind_err_line:
             match = re.search("<kind>(.+)</kind> in .+/(.+)", line)
             if not match:
                 log.warning("Misunderstood line: {0}".format(line))