[PREVIEW] teuthology: add support for graph walks of QA suites #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 4, 2024 03:16
This is unrelated to graph walking but makes testing much easier to iterate on. It's not necessary to clone the QA suite whenever the commit changes; instead clone once and fetch the difference. Reviewer's note: this commit needs cleaned up, obviously. This is part of a preview. Signed-off-by: Patrick Donnelly <[email protected]>
Reviewer's note: this is part of a preview PR. This lacks tests/docs. There is more documentation to do. Also, the code needs one small improvement: - To maintain consistency with the --subset operator on matrices, we should ensure that each fragment is included at least once in a subset (if the subset is large enough to make that possible). The probable way to do that is to generate the randomized set of children for each node once and always pull the first child if a path should be generated (then put that child at the end of the queue of children). Signed-off-by: Patrick Donnelly <[email protected]>
Reviewer's note: we will probably want to make the matrix representation a valid fallback using a command line switch. This is also important when doing reruns with subsets generated via the matrix representation. Signed-off-by: Patrick Donnelly <[email protected]>
batrick
changed the title
kshtsk
reviewed
Dec 4, 2024
| @@ -95,7 +95,7 @@ def current_branch(path: str) -> str: | |||
| return result | |||
|
|
|||
|
|
|||
| def enforce_repo_state(repo_url, dest_path, branch, commit=None, remove_on_error=True): | |||
| def enforce_repo_state(dest_clone, dest_path, repo_url, branch, commit=None, remove_on_error=True): | |||
There was a problem hiding this comment.
I'd prefer not to change initial signature and leave repo_url at first position, and add dest_cone as an optional argument with defaults value.
There was a problem hiding this comment.
Sure, there will probably be lots of reworking to this code but it was a dirty hack to start because the clones after every QA suite tweak was driving me nuts. That's why it's in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preview PR for the branch used for my talk at Cephalocon 2024:
https://ceph2024.sched.com/event/1ktVR/the-art-of-teuthology-patrick-donnelly-ibm-inc
TODO:
should ensure that each fragment is included at least once in a subset
(if the subset is large enough to make that possible). The probable
way to do that is to generate the randomized set of children for each
node once and always pull the first child if a path should be
generated (then put that child at the end of the queue of children).
radoscreates 4455758 jobs whereas graph implementation creates 2792029 jobs. This may be a divergence caused by nested subsets but needs investigation.